Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add lely-core/2.3.2 #15151

Merged
merged 32 commits into from
Jan 23, 2023
Merged

add lely-core/2.3.2 #15151

merged 32 commits into from
Jan 23, 2023

Conversation

uyha
Copy link
Contributor

@uyha uyha commented Jan 7, 2023

Specify library name and version: lely-core/2.3.1

lely-core is a library for interacting with CANopen and it is not available on Conan Center yet, so I want to have it available there.


@uyha uyha changed the title add lely add /2.3.1 Jan 8, 2023
@uyha uyha changed the title add /2.3.1 add lely/2.3.1 Jan 8, 2023
@uyha uyha changed the title add lely/2.3.1 add lely-core/2.3.1 Jan 9, 2023
@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@uyha uyha requested review from uilianries and AbrilRBS and removed request for AbrilRBS and uilianries January 13, 2023 23:01
@uyha
Copy link
Contributor Author

uyha commented Jan 20, 2023

@uilianries @RubenRBS @prince-chrismc I'm really sorry for tagging and pushing, but I need to use this library in a project and would like to import it through Conan, and I think this package is ready to be merged in. Could you review it again?

uilianries
uilianries previously approved these changes Jan 20, 2023
Copy link
Member

@uilianries uilianries left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

recipes/lely-core/all/conandata.yml Outdated Show resolved Hide resolved
@prince-chrismc
Copy link
Contributor

I'm really sorry for tagging and pushing, but I need to use this library in a project and would like to import it through Conan, and I think this package is ready to be merged in. Could you review it again?

You can check my bot prince-chrismc/conan-center-index-pending-review#1 so learn about the status of all PRs there are fun graphs at the bottom

it's currently taking ~16 days for PRs to merge so you'll need to be patient as we have a huge backlog from the holidays

@uyha
Copy link
Contributor Author

uyha commented Jan 20, 2023

I'm really sorry for tagging and pushing, but I need to use this library in a project and would like to import it through Conan, and I think this package is ready to be merged in. Could you review it again?

You can check my bot prince-chrismc/conan-center-index-pending-review#1 so learn about the status of all PRs there are fun graphs at the bottom

it's currently taking ~16 days for PRs to merge so you'll need to be patient as we have a huge backlog from the holidays

I checked that, but I became anxious (due to no review, and pressure to use it) so I am really sorry again for this.

@AbrilRBS
Copy link
Member

No worries, we understand that it's hard when you feel like your PR gets ignored, but as Chris said, it's not the case! We're just running a bit behind due to the holidays :)

@conan-center-bot

This comment has been minimized.

@uyha uyha changed the title add lely-core/2.3.1 add lely-core/2.3.2 Jan 21, 2023
@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ✔️

All green in build 37 (a46140c1529062d76d5a0155d551fa584fc766d2):

  • lely-core/2.3.2@:
    All packages built successfully! (All logs)

Copy link
Member

@uilianries uilianries left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@conan-center-bot conan-center-bot merged commit 9144447 into conan-io:master Jan 23, 2023
StellaSmith pushed a commit to StellaSmith/conan-center-index that referenced this pull request Feb 2, 2023
* add lely

* fix lint error

* add description

* add patch information

* add patch_source

* change name from lely to lely-core

* fix url and homepage attributes

* add test for conan v1

* link thread library in test package

* include LICENSE file and remove pkgconfig and .la files

* switch to explicit typing to satisfy C++11 construction

* fix conanfile.py for conan v1 and fix test

* specify C++ version when compiling test

* fix conanfile.py for test package conan v1

* correct path of executable

* remove fPIC when building shared library

* specify system libraries

* use rm_safe instead of del

* include conanbuildinfo.cmake

* correct executable path

* fix v2 test

* try different way of importing

* force compile with gcc only

* fix typo and move comment into the error message

* change license to SPDX short-name form

* clarify error messages

* use configure_args AutotoolsToolchain instead of passing them as an argument

* move configuring arguments to generate method

* reuse test_package's CMake script in test_v1_package

* add version 2.3.2

* remove version 2.3.1

* remove unnecessary Threads::Threads linking
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants