Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

accellera-uvm-systemc: systemc lib is required for uvm-systemc #16361

Merged
merged 3 commits into from
Mar 16, 2023

Conversation

staskau
Copy link
Contributor

@staskau staskau commented Mar 3, 2023

Specify library name and version: accellera-uvm-systemc/1.0-beta4

This is a bug fix in conanfile.py: systemc was declared as a tool_requirement, but systemc is is not a tool. This is a library required for uvm-systemc.
For some reason it worked fine in the past, but now tool_requires("systemc/2.3.3") leads to the following error message:

accellera-uvm-systemc/1.0-beta4: ERROR: Package 'b911f48570f9bb2902d9e83b2b9ebf9d376c8c56' build failed
accellera-uvm-systemc/1.0-beta4: WARN: Build folder /home/stas/.conan/data/accellera-uvm-systemc/1.0-beta4/_/_/build/b911f48570f9bb2902d9e83b2b9ebf9d376c8c56
ERROR: accellera-uvm-systemc/1.0-beta4: Error in build() method, line 56
args = [f"--with-systemc={self.deps_cpp_info['systemc'].rootpath}"]
KeyError: 'systemc'

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@staskau
Copy link
Contributor Author

staskau commented Mar 14, 2023

Is there any problem with reviewing and merging this pull request? Should anything be added or changed?

@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ✔️

All green in build 4 (5073a6e3ece1032b0cf3beb19fb9110473ded2eb):

  • accellera-uvm-systemc/1.0-beta4@:
    All packages built successfully! (All logs)

Conan v2 pipeline (informative, not required for merge) ❌

Note: Conan v2 builds are informative and they are not required for the PR to be merged.

The v2 pipeline failed. Please, review the errors and note this will be required for pull requests to be merged in the near future.

See details:

Failure in build 3 (5073a6e3ece1032b0cf3beb19fb9110473ded2eb):

  • accellera-uvm-systemc/1.0-beta4@:
    Error running command conan export --name accellera-uvm-systemc --version 1.0-beta4 recipes/accellera-uvm-systemc/all/conanfile.py:
    ======== Exporting recipe to the cache ========
    ERROR: Error loading conanfile at '/home/conan/w/prod-v2_cci_PR-16361/recipes/accellera-uvm-systemc/all/conanfile.py': Unable to load conanfile in /home/conan/w/prod-v2_cci_PR-16361/recipes/accellera-uvm-systemc/all/conanfile.py
      File "<frozen importlib._bootstrap_external>", line 728, in exec_module
      File "<frozen importlib._bootstrap>", line 219, in _call_with_frames_removed
      File "/home/conan/w/prod-v2_cci_PR-16361/recipes/accellera-uvm-systemc/all/conanfile.py", line 2, in <module>
        from conans import AutoToolsBuildEnvironment
    ImportError: cannot import name 'AutoToolsBuildEnvironment' from 'conans' (/opt/pyenv/versions/3.7.13/lib/python3.7/site-packages/conans/__init__.py)
    

Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability.

Copy link
Member

@memsharded memsharded left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @staskau

Sorry for the delay, the backlog in ConanCenter is very large.
This is looking good, thanks for your contribution. Just a note of warning, this recipe is not ready for Conan 2.0 (same for systemc), still can be merged, but eventually it will need to be updated to be built in ConanCenter.

@prince-chrismc
Copy link
Contributor

prince-chrismc/conan-center-index-pending-review#1

You can see there is a big deal happening, you can use that board to see the state of PRs

image

@conan-center-bot conan-center-bot merged commit 4181a32 into conan-io:master Mar 16, 2023
0xFireWolf pushed a commit to 0xFireWolf/conan-center-index that referenced this pull request Apr 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants