Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lunasvg: add version 3.0.0 #25613

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

lunasvg: add version 3.0.0 #25613

wants to merge 3 commits into from
+81 −3

Conversation

toge
Copy link
Contributor

@toge toge commented Oct 13, 2024

Summary

Changes to recipe: lunasvg/3.0.0

Motivation

This is a major version up.

Details

sammycage/lunasvg@v2.4.1...v3.0.0

@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot

This comment has been minimized.

Sign in to view
This was referenced Oct 13, 2024
Open
Open
@AbrilRBS AbrilRBS self-assigned this Oct 14, 2024
ErniGH
ErniGH reviewed Oct 14, 2024
View reviewed changes
Copy link
Contributor

@ErniGH ErniGH left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.

ErniGH
ErniGH approved these changes Oct 14, 2024
View reviewed changes
Copy link
Contributor

@ErniGH ErniGH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ✔️

Warning

Conan Center will stop receiving updates for Conan 1.x packages soon - please see announcement.

All green in build 3 (ff966e792bd52c2a4982817aede0b8b85699ad36):

  • lunasvg/2.4.1:
    All packages built successfully! (All logs)

  • lunasvg/2.3.2:
    All packages built successfully! (All logs)

  • lunasvg/2.3.4:
    Built 18 packages out of 22 (All logs)

  • lunasvg/2.3.8:
    Built 18 packages out of 22 (All logs)

  • lunasvg/2.3.5:
    Built 18 packages out of 22 (All logs)

  • lunasvg/2.3.9:
    All packages built successfully! (All logs)

  • lunasvg/3.0.0:
    Built 18 packages out of 22 (All logs)

  • lunasvg/2.4.0:
    All packages built successfully! (All logs)

  • lunasvg/2.3.1:
    All packages built successfully! (All logs)

Conan v2 pipeline ✔️

Note: Conan v2 builds are now mandatory. Please read our discussion about it.

All green in build 3 (ff966e792bd52c2a4982817aede0b8b85699ad36):

  • lunasvg/3.0.0:
    All packages built successfully! (All logs)

  • lunasvg/2.3.8:
    All packages built successfully! (All logs)

  • lunasvg/2.4.1:
    All packages built successfully! (All logs)

  • lunasvg/2.4.0:
    All packages built successfully! (All logs)

  • lunasvg/2.3.5:
    All packages built successfully! (All logs)

  • lunasvg/2.3.2:
    All packages built successfully! (All logs)

  • lunasvg/2.3.9:
    All packages built successfully! (All logs)

  • lunasvg/2.3.4:
    All packages built successfully! (All logs)

  • lunasvg/2.3.1:
    All packages built successfully! (All logs)

AbrilRBS
AbrilRBS reviewed Oct 15, 2024
View reviewed changes
recipes/lunasvg/all/test_v1_package/CMakeLists.txt
@@ -8,4 +8,14 @@ find_package(lunasvg REQUIRED CONFIG)

add_executable(${PROJECT_NAME} ../test_package/test_package.cpp)
target_link_libraries(${PROJECT_NAME} PRIVATE lunasvg::lunasvg)
target_compile_features(${PROJECT_NAME} PRIVATE cxx_std_14)
if (lunasvg_VERSION VERSION_LESS_EQUAL "2.3.2")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this cxx version logic is wrong - 3.0.0 should have c++17 right?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AbrilRBS AbrilRBS AbrilRBS left review comments

@ErniGH ErniGH ErniGH approved these changes

At least 2 approving reviews are required to merge this pull request.

Assignees

@AbrilRBS AbrilRBS

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@toge @conan-center-bot @AbrilRBS @ErniGH