Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libnftnl: add new recipe (#26198) #26200

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

libnftnl: add new recipe (#26198) #26200

wants to merge 3 commits into from
+114 −0

Conversation

nikitasinys
Copy link
Contributor

@nikitasinys nikitasinys commented Dec 16, 2024 •
edited
Loading

Summary

Add new recipe: libnftnl/[1.2.8], fixes #26198

Motivation

This library helps to work with nf_tables subsystem

@nikitasinys nikitasinys marked this pull request as draft December 16, 2024 10:44
@nikitasinys nikitasinys marked this pull request as ready for review December 16, 2024 10:58
valgur
valgur suggested changes Dec 16, 2024
View reviewed changes
Copy link
Contributor

@valgur valgur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM. The Windows shared validation needs to be moved to validate().

recipes/libnftnl/all/conanfile.py Show resolved Hide resolved
recipes/libnftnl/all/conanfile.py Show resolved Hide resolved
recipes/libnftnl/all/conanfile.py Outdated Show resolved Hide resolved
recipes/libnftnl/all/conanfile.py Outdated Show resolved Hide resolved
recipes/libnftnl/all/test_package/conanfile.py Outdated Show resolved Hide resolved
recipes/libnftnl/all/conanfile.py Outdated Show resolved Hide resolved
@nikitasinys nikitasinys marked this pull request as draft December 16, 2024 12:13
@nikitasinys
Copy link
Contributor Author

Thanks! LGTM. The Windows shared validation needs to be moved to validate().

Thanks for review!

@nikitasinys nikitasinys marked this pull request as ready for review December 16, 2024 13:29
@nikitasinys nikitasinys requested a review from valgur December 17, 2024 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@valgur valgur Awaiting requested review from valgur

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[request] libnftnl/1.2.8
2 participants
@nikitasinys @valgur