Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add ptz to header list and added new version (3.0.1) #5706

Merged
merged 4 commits into from
Jun 2, 2021
Merged

add ptz to header list and added new version (3.0.1) #5706

merged 4 commits into from
Jun 2, 2021

Conversation

paulocoutinhox
Copy link
Contributor

Specify library name and version: date/all

This is also a good place to share with all of us why you are submitting this PR (specially if it is a new addition to ConanCenter): is it a dependency of other libraries you want to package? Are you the author of the library? Thanks!


  • I've read the guidelines for contributing.
  • I've followed the PEP8 style guides for Python code in the recipes.
  • I've used the latest Conan client version.
  • I've tried at least one configuration locally with the
    conan-center hook activated.

@CLAassistant
Copy link

CLAassistant commented May 31, 2021

CLA assistant check
All committers have signed the CLA.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

Comment on lines 90 to 95
self.copy(pattern="date.h", dst=dst, src=src)
self.copy(pattern="tz.h", dst=dst, src=src)
self.copy(pattern="ptz.h", dst=dst, src=src)
self.copy(pattern="iso_week.h", dst=dst, src=src)
self.copy(pattern="julian.h", dst=dst, src=src)
self.copy(pattern="islamic.h", dst=dst, src=src)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel like this is easier 🌮

Suggested change
self.copy(pattern="date.h", dst=dst, src=src)
self.copy(pattern="tz.h", dst=dst, src=src)
self.copy(pattern="ptz.h", dst=dst, src=src)
self.copy(pattern="iso_week.h", dst=dst, src=src)
self.copy(pattern="julian.h", dst=dst, src=src)
self.copy(pattern="islamic.h", dst=dst, src=src)
for file in ["date.h", "tz.h", "ptz.h", "iso_week.h", "julian.h", "islamic.h"]:
self.copy(pattern=file, dst=dst, src=src)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi. This is required? Because will reset reviews, build etc.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can add it after this PR, because this PR is required to use this library correctly. Can we do in this way?

Copy link
Contributor

@prince-chrismc prince-chrismc Jun 1, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not required, I approved! hopefully next time this recipe gets updated ... there's a few out of date conventions

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

at university, on 1st semester, there was an exercise about for loop, the idea was print from 1 to 10 using C language. A colleague preferred to write printf 10 times, each line for a single number ... don't try it at home.

@prince-chrismc
Copy link
Contributor

Please update the title to include the new version add please =)

@paulocoutinhox paulocoutinhox changed the title add ptz to header list add ptz to header list and added new version (3.0.1) Jun 1, 2021
@conan-center-bot

This comment has been minimized.

@prince-chrismc
Copy link
Contributor

Unresolved graph? 😖

You'll need to retrigger CI, close the pr wait 10s and then re-open it 🔁

@paulocoutinhox
Copy link
Contributor Author

Unresolved graph? 😖

You'll need to retrigger CI, close the pr wait 10s and then re-open it 🔁

done

@conan-center-bot
Copy link
Collaborator

All green in build 7 (db031b281039cc3d1a9e43d692f4d77cf9e254e5):

  • date/2.4.1@:
    All packages built successfully! (All logs)

  • date/3.0.0@:
    All packages built successfully! (All logs)

  • date/3.0.1@:
    All packages built successfully! (All logs)

@paulocoutinhox
Copy link
Contributor Author

Unresolved graph? 😖
You'll need to retrigger CI, close the pr wait 10s and then re-open it 🔁

done

all green again

@prince-chrismc
Copy link
Contributor

CI should merge it soon =)

@paulocoutinhox
Copy link
Contributor Author

CI should merge it soon =)

I think that need more one reviewer, no?

@prince-chrismc
Copy link
Contributor

prince-chrismc commented Jun 2, 2021

@conan-center-bot conan-center-bot merged commit 420d253 into conan-io:master Jun 2, 2021
@paulocoutinhox paulocoutinhox deleted the date-ptz branch June 2, 2021 20:09
madebr pushed a commit to madebr/conan-center-index that referenced this pull request Jun 21, 2021
* add ptz to header list

* add ptz to header list

* add version 3.0.1

* add patch for version 3.0.1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants