Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Style.icon #194

Merged
merged 3 commits into from
Feb 5, 2024
Merged

Implement Style.icon #194

merged 3 commits into from
Feb 5, 2024

Conversation

tilucasoli
Copy link
Collaborator

Describe your changes

  • Implement static func to receive only icon attributes

Type of change

  • New feature (non-breaking change which adds functionality)

Checklist before requesting a review

  • I have performed a self-review of my code
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works

Copy link

vercel bot commented Feb 3, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
mix-docs ⬜️ Ignored (Inspect) Visit Preview Feb 4, 2024 0:30am

@tilucasoli
Copy link
Collaborator Author

tilucasoli commented Feb 3, 2024

I realized that we don't have documentation for the new way to use attributes.
@leoafarias

Style(
    box.color.red(),
)

@tilucasoli tilucasoli changed the title Feat/style icon Implement Style.icon Feb 3, 2024
Copy link
Member

@leoafarias leoafarias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@leoafarias leoafarias merged commit 255ce3a into main Feb 5, 2024
6 checks passed
@leoafarias leoafarias deleted the feat/style-icon branch February 5, 2024 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants