Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: callable specs and modifiers #332

Merged
merged 7 commits into from
Jun 27, 2024
Merged

fix: callable specs and modifiers #332

merged 7 commits into from
Jun 27, 2024

Conversation

tilucasoli
Copy link
Collaborator

Description

Some fixes in call methods and modifiers structure

Changes

  • Make WithModifierUtility a generic class and receive a builder in its constructor;
  • Make callable specs have the same parameters as the spec widget constructor;
  • Fix PaddingModifierAttribute merge.

Review Checklist

  • Testing: Have you tested your changes, including unit tests and integration tests for affected code?
  • Breaking Changes: Does this change introduce breaking changes affecting existing code or users?
  • Documentation Updates: Are all relevant documentation files (e.g. README, API docs) updated to reflect the changes in this PR?
  • Website Updates: Is the website containing the updates you make on documentation?

Impacted Packages

Please indicate which packages in our project are affected by these changes:

  • mix
  • mix_lint
  • mix_generator
  • documentation

Additional Information (optional)

Looking at the WithModifierUtility changes, maybe it can be a breaking change in specific scenarios. What do you think @leoafarias?

Copy link

vercel bot commented Jun 26, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
mix-docs ⬜️ Ignored (Inspect) Visit Preview Jun 27, 2024 6:36pm

Copy link
Contributor

github-actions bot commented Jun 26, 2024

DCM report

✅ no issues found!

Full report: https://github.com/conceptadev/mix/runs/26730908855

@leoafarias leoafarias merged commit 9b9332d into main Jun 27, 2024
4 checks passed
@leoafarias leoafarias deleted the fix/callables branch June 27, 2024 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants