Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update pin for pytorch #4305

Conversation

regro-cf-autotick-bot
Copy link
Contributor

This PR has been triggered in an effort to update the pin for pytorch. The current pinned version is 1.13, the latest available version is 2.0 and the max pin pattern is x.x. This migration will impact 25 feedstocks.

Checklist:

  • The new version is a stable supported pin.
  • I checked that the ABI changed from 1.13 to 2.0.

**Please note that if you close this PR we presume that the new pin has been rejected.

@conda-forge-admin please ping pytorch-cpu
This PR was generated by https://github.com/regro/cf-scripts/actions/runs/4612719562, please use this URL for debugging

@regro-cf-autotick-bot regro-cf-autotick-bot requested a review from a team as a code owner April 4, 2023 23:42
@conda-forge-webservices
Copy link
Contributor

Hi! This is the friendly automated conda-forge-webservice.

I was asked to ping @conda-forge/pytorch-cpu and so here I am doing that.

@conda-forge-webservices
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@hmaarrfk
Copy link
Contributor

hmaarrfk commented Apr 4, 2023

@Tobias-Fischer do you want this before the torvision update?

@Tobias-Fischer
Copy link
Contributor

Let's wait a little till we have figured out the triton stuff?

@h-vetinari
Copy link
Member

@Tobias-Fischer do you want this before the torvision update?

torchvision is running into issues regardless... conda-forge/torchvision-feedstock#71

Though those aren't a huge deal and can be worked around in other ways, so I'm not proposing to hurry. Still...

Let's wait a little till we have figured out the triton stuff?

IIUC, triton is not essential for the operation of pytorch? Can we uncouple the 2.0 migration from improving the triton-integration?

@Tobias-Fischer
Copy link
Contributor

Sure fine with me

@hmaarrfk
Copy link
Contributor

hmaarrfk commented Apr 7, 2023

ok lets see what happens.

@hmaarrfk hmaarrfk merged commit 296045b into conda-forge:main Apr 7, 2023
@regro-cf-autotick-bot regro-cf-autotick-bot deleted the new_pin-pytorch-2.0-0-_h2bf9b8 branch April 7, 2023 02:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants