-
-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rebuild for hurry.filesize 0.9 is not supported on this platform #1
Conversation
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( I do have some suggestions for making it better though... For recipe/meta.yaml:
Documentation on acceptable licenses can be found here. |
@conda-forge-admin, please rerender |
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
@conda-forge-admin, please rerender |
…nda-forge-pinning 2024.08.17.00.11.41
@raivivek - could you review and merge please. |
@conda-forge-admin, please rerender |
…nda-forge-pinning 2024.08.21.07.06.37
@conda-forge/core - Can I be added as a maintainer - I am happy to help keep this feedstock updated. Recipe has been refreshed and this PR (Description), will Rebuild for PiP Check Error |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Normally we ask to wait for 1-2 weeks to give the maintainers time to respond, but based on the GH profile of the sole maintainer here, they haven't had any activity in conda-forge for at least a year (last blip was some bioconda stuff in October 2023), so I don't think there's a big chance for a response either way.
name: hurry.filesize | ||
name: {{ name|lower }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As an aside, this is a pessimization in my eyes. Yes, the bot autogenerates this format, but it gives the false impression that the name is a variable that could be changed, and has zero benefits, only downsides (e.g. it makes it harder to copy-paste the correct URL). If any thing, you should be replacing {{ name|lower }}
when you encounter one in a recipe, but at the very least please don't introduce it where it doesn't exist.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@h-vetinari
Did not know that - Grayskull generates with name: {{ name|lower }}, and that's always prompted making the change - and I thought I was making things better / more standard by replacing with the variable. !
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
People can have different opinions which is better or worse, and though mine is pretty clear, it's certainly not the end of the world. The name variable is IMO an artefact of the automatisation approach (it's already a variable in grayskull, so the impulse to reuse it is there by default), but I haven't had the time to go fix it at the source. Probably I should one of these days...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Had started to in PR: conda/grayskull#548
Probably needs some tweaks before it can be merged
Checklist
0
(if the version changed)conda-smithy
(Use the phrase@conda-forge-admin, please rerender
in a comment in this PR for automated rerendering)conda-forge/django-handyhelpers-feedstock#18