Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add aim-ui #21651

Merged
merged 3 commits into from
Jan 10, 2023
Merged

add aim-ui #21651

merged 3 commits into from
Jan 10, 2023

Conversation

hadim
Copy link
Member

@hadim hadim commented Jan 3, 2023 •
edited
Loading

Checklist

  • Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml".
  • License file is packaged (see here for an example).
  • Source is from official source.
  • Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged).
  • If static libraries are linked in, the license of the static library is packaged.
  • Package does not ship static libraries. If static libraries are needed, follow CFEP-18.
  • Build number is 0.
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details).
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.
  • When in trouble, please check our knowledge base documentation before pinging a team.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/aim-ui) and found some lint.

Here's what I've got...

For recipes/aim-ui:

  • noarch: python recipes are required to have a lower bound on the python version. Typically this means putting python >=3.6 in both host and run but you should check upstream for the package's Python compatibility.

@hadim hadim mentioned this pull request Jan 3, 2023
Merged
5 tasks
@hadim
Copy link
Member Author

hadim commented Jan 3, 2023

Required for conda-forge/aim-feedstock#14

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/aim-ui) and found it was in an excellent condition.

@hadim
Copy link
Member Author

hadim commented Jan 3, 2023

@conda-forge/help-python ready for review

@hadim hadim mentioned this pull request Jan 4, 2023
Merged
10 tasks
hadim
hadim commented Jan 4, 2023
View reviewed changes
recipes/aim-ui/meta.yaml
@@ -38,3 +38,4 @@ about:
extra:
recipe-maintainers:
- hadim
- gorarakelyan
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See #21653 (comment) for approval

@beckermr beckermr merged commit 2aa3884 into conda-forge:main Jan 10, 2023
@hadim hadim deleted the aim-ui branch January 10, 2023 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
python review-requested
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hadim @conda-forge-linter @beckermr