Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add litescope #26093

Merged
merged 3 commits into from
May 10, 2024
Merged

add litescope #26093

merged 3 commits into from
May 10, 2024

Conversation

timkpaine
Copy link
Member

Checklist

  • Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml".
  • License file is packaged (see here for an example).
  • Source is from official source.
  • Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged).
  • If static libraries are linked in, the license of the static library is packaged.
  • Package does not ship static libraries. If static libraries are needed, follow CFEP-18.
  • Build number is 0.
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details).
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.
  • When in trouble, please check our knowledge base documentation before pinging a team.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/litescope) and found it was in an excellent condition.

@timkpaine timkpaine marked this pull request as ready for review April 18, 2024 21:03
@timkpaine
Copy link
Member Author

@conda-forge/help-python all set!

xhochy
xhochy requested changes May 10, 2024
View reviewed changes
recipes/litescope/meta.yaml
- migen

test:
imports:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a call to pip check or a comment of why you are omitting it.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same as lite* #26117 (comment)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this work is under the umbrella of enjoy-digital/liteeth#159 in case you're curious

@xhochy xhochy merged commit 7a7651f into conda-forge:main May 10, 2024
5 checks passed
@timkpaine timkpaine deleted the tkp/litescope branch May 10, 2024 22:45
@timkpaine timkpaine mentioned this pull request May 10, 2024
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xhochy xhochy xhochy requested changes

Assignees
No one assigned
Labels
python review-requested
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@timkpaine @xhochy