tdx-attester: make DCAP libs optional #572
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
'all-attesters' is a default feature for the crate so it does not have to be set as a dependency to bin. In fact, it can be useful to be able to select a subset of the attesters, e.g., cargo build --no-default-features --features bin,tdx-attester --bin evidence_getter --release Moreover, with --no-default-features, 'codicon' becomes missing so set it as a mandatory dependency instead. Signed-off-by: Mikko Ylinen <[email protected]>
The attester crate pulls in DCAP 1.20 which only supports /dev/tdx_guest ioctls so the two other (legacy) character devices can be dropped. However, this triggers another issue: we can have /dev/tdx_guest ioctls (e.g., the RTMR extend) that are not part of Linux upstream so the recently added runtime_measurement_extend_available() won't work anymore. This change tries to mitigate that (for the time being) by making the simplification that "if TSM reports, no RTMRs". Signed-off-by: Mikko Ylinen <[email protected]>
Signed-off-by: Mikko Ylinen <[email protected]>
It can be useful, e.g., when testing RCAR protocol with kbs-client, to be able to just have get_evidence() from the TDX attester without the need to have libtdx-attest/*-dev available. Signed-off-by: Mikko Ylinen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Still WIP/RFC.
In #434 I had proposed to make use of
tdx-attest-rsbehind a new feature but dropped the idea since the initdata work moved to use it too and that is a valid case event with upstream kernels.However, @fidencio mentioned a use case that building
kbs-clientwithout having to installlibtdx-attest*(because of added complexity and the fact that the libs are not yet avail on all OS'es, e.g, 24.04) but still get the basicget_evidence()working can be useful. So I restored my original code and added here for feedback on how it's best handled.