Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Image-rs & CDH | Refactoring and use the same ImageClient #708

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Commits on Sep 27, 2024

  1. image-rs: refactor signature module

    Refactor signature module from function way to object oriented. Also
    changed the logic a little to avoid duplicated get resource operation.
    
    Signed-off-by: Xynnn007 <[email protected]>
    Xynnn007 committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    3fcd663 View commit details
    Browse the repository at this point in the history
  2. image-rs: refactor resource module

    change the whole resource module's API into an object. This would help
    to make the modularation clear and better maintainance.
    
    Also, change the feature `getresource` to `kbs`. Because this feature
    only adds supports to find resources with `kbs:///` uri scheme.
    
    deletes useless lines in Cargo.toml
    
    Signed-off-by: Xynnn007 <[email protected]>
    Xynnn007 committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    6f5a672 View commit details
    Browse the repository at this point in the history
  3. image-rs: refactor auth module

    Now auth is a separate module with an object. This would help to
    maintain the internal status of each auth module.
    
    Signed-off-by: Xynnn007 <[email protected]>
    Xynnn007 committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    05266d8 View commit details
    Browse the repository at this point in the history
  4. image-rs & CDH: add ClientBuilder logic

    With clientBuilder, we can get registry auth, sigstore config file and
    image policy when the client is built.
    
    This would help to avoid duplicated file getting.
    
    Also, combined CDH's image config with image-rs'.
    To leverage the new client builder, we mark the image pull object as a
    static one to be lazily initialized. Because before CDH is set up, the
    initialization steps of image client cannot pass when fetching resources
    from KBS.
    
    Signed-off-by: Xynnn007 <[email protected]>
    Xynnn007 committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    8bd4371 View commit details
    Browse the repository at this point in the history
  5. image-rs: fix integration test

    Signed-off-by: Xynnn007 <[email protected]>
    Xynnn007 committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    5f2df22 View commit details
    Browse the repository at this point in the history
  6. ci: update image-rs feature name getresource to kbs

    Now we use kbs to refer to the old feature getresource
    
    Signed-off-by: Xynnn007 <[email protected]>
    Xynnn007 committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    9e75e02 View commit details
    Browse the repository at this point in the history

Commits on Oct 9, 2024

  1. image-rs: use proxy config rather than env

    New dependency oci-client version supports to set HTTPS_PROXY and
    NO_PROXY without setting env of the whole process.
    
    Also, this commit marks the cosign module's client TODO to add a proxy
    configuration.
    
    Signed-off-by: Xynnn007 <[email protected]>
    Xynnn007 committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    7c750ad View commit details
    Browse the repository at this point in the history

Commits on Oct 14, 2024

  1. Configuration menu
    Copy the full SHA
    d378288 View commit details
    Browse the repository at this point in the history