Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Codify the creation of test containers #16

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

portersrc
Copy link
Member

@portersrc portersrc commented Oct 4, 2024

Not ready for review. Placeholder for CI meeting on Oct 9, 2024.

Meant as a starting point to address:
kata-containers/kata-containers#9360

Some points for initial discussion:

  1. Do we really (really) want to put this in operator, or is infra ok?
  2. CoCo packages is not well organized. Can we have a naming scheme for these new images? It would also help avoid collisions while we work through all existing test cases that use these images.
  3. There may be requirements from the github maintainers to set some stuff, e.g. secrets.COSIGN_PASSWORD. Alternatively, these are just tests, so we can just use regular strings.

Copy link
Member

@stevenhorsman stevenhorsman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Triggering suggestion

@@ -0,0 +1,55 @@
name: Build Test Containers
run-name: Build Test Containers
on: [push]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we add the option to manually trigger them? e.g. if we might want to re-gen them to check the e2e process is still working? Also we might only want to run this automatically if a related file changes if we end up using this repo for other thing?

Suggested change
on: [push]
on:
workflow_dispatch:
push:
branches:
- 'main'
paths:
- 'container-images'
- '.github/workflows/build-test-containers.yaml'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants