Build ESM artifacts with Node16 moduleResolution #1104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smaye81
commented
Jun 14, 2024
smaye81
commented
Jun 14, 2024
|
@timostamm here's an attempt at Node16 moduleResolution in connect-es. Left a few questions inside. Let me know what you think. |
Signed-off-by: Steve Ayers <[email protected]>
Signed-off-by: Steve Ayers <[email protected]>
Signed-off-by: Steve Ayers <[email protected]>
Signed-off-by: Steve Ayers <[email protected]>
Signed-off-by: Steve Ayers <[email protected]>
Signed-off-by: Steve Ayers <[email protected]>
smaye81
force-pushed
the
sayers/node16_module_resolution
branch
from
187898c
to
a196662
Compare
timostamm
approved these changes
Jun 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #887
This switches all packages to build ESM artifacts with Node16 module resolution. In doing so, it turns on Node16 for both
moduleResolutionandmoduleby default throughout the repo. It also turns onverbatimModuleSyntaxby default.For CJS artifacts, the exceptions for
moduleResolution node10andverbatimModuleSyntax falseare now specified in the command script.