V2: Correct type inference for ConnectError#findDetails #1188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bhollis
changed the title
timostamm
reviewed
Aug 27, 2024
There was a problem hiding this comment.
Thanks, Ben!
Could you sign the commit? See here for details.
Signed-off-by: Ben Hollis <[email protected]>
bhollis
force-pushed
the
v2-findDetails
branch
from
e9fc391
to
cae94ce
Compare
|
Updated with signoff |
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed a minor issue with the types for
findDetailsthat prevented correct type inference for the return type. e.g.:I wanted
detailsto be typeMyDetails[]but instead it'sMessage<string>[]. The change in this PR fixes it.