Fix baseUrl without // mangling request URL on Node.js with HTTP/2 #1220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Timo Stamm <[email protected]>
timostamm
commented
Sep 9, 2024
| @@ -280,7 +280,7 @@ function h2Request( | |||
| options: Omit<http2.ClientSessionRequestOptions, "signal">, | |||
| onStream: (stream: http2.ClientHttp2Stream) => void, | |||
| ): void { | |||
| const requestUrl = new URL(url, sm.authority); | |||
| const requestUrl = new URL(url); | |||
There was a problem hiding this comment.
The URL constructor parses https:localhost:8443, but not when the base argument is given.
The result here used to be https://localhost:8443/localhost:8443/connectrpc.eliza.v1.ElizaService/Introduce, and is now the expected https://localhost:8443/connectrpc.eliza.v1.ElizaService/Introduce.
IIRC, the authority was only given as a base to potentially support relative URLs, but I don't actually see us supporting them in a meaningful way with this HTTP client.
srikrsna-buf
approved these changes
Sep 9, 2024
timostamm
deleted the
tstamm/Fix-baseUrl-without-slash-mangling-request-URL-on-Node.js-with-HTTP2
branch
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #958