Update references for crosstests #85
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pkwarren
reviewed
Sep 5, 2023
.github/workflows/ci.yml
Outdated
| - name: Run crosstests | ||
| run: make crosstestsrun | ||
| - name: Generate proto files for conformance tests. | ||
| run: make generateconformance |
There was a problem hiding this comment.
The conformance tests relied on more generated code than the stuff in crosstests dir so I added a Make dependency on generate for running the crosstests. We can now simplify this to remove this step entirely.
| @@ -12,7 +12,7 @@ | |||
| // See the License for the specific language governing permissions and | |||
| // limitations under the License. | |||
|
|
|||
| package build.buf.connect.crosstest.ssl | |||
| package connectrpc.conformance.ssl | |||
There was a problem hiding this comment.
The package should be com.connectrpc.*.
pkwarren
reviewed
Sep 5, 2023
| @@ -25,7 +25,7 @@ sourceSets { | |||
| dependencies { | |||
| implementation(libs.kotlin.coroutines.core) | |||
| implementation(libs.protobuf.kotlin) | |||
| implementation(project(":crosstests:common")) | |||
| implementation(project(":conformance:common")) | |||
There was a problem hiding this comment.
This file is losing the .kts extension as part of the rename (which looks like it might be why the CI workflows are failing).
pkwarren
reviewed
Sep 5, 2023
| @@ -12,7 +12,7 @@ | |||
| // See the License for the specific language governing permissions and | |||
| // limitations under the License. | |||
|
|
|||
| package connectrpc.conformance.ssl | |||
| package com.connectrpc.conformance.ssl | |||
There was a problem hiding this comment.
The files should also be moved to the right locations - i.e. conformance/common/src/main/kotlin/connectrpc/conformance/ssl/SSL.kt -> conformance/common/src/main/kotlin/com/connectrpc/conformance/ssl/SSL.kt
pkwarren
approved these changes
Sep 5, 2023
pkwarren
approved these changes
Sep 6, 2023
pkwarren
approved these changes
Sep 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the repo to use
connectrpc/conformanceinstead ofbufbuild/connect-crosstest.Note this is not expected to build / merge until the crosstest repo is officially moved to connectrpc.