Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify Connect error debug property type #199

Merged
merged 1 commit into from
Sep 10, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions docs/protocol.md
Original file line number Diff line number Diff line change
Expand Up @@ -595,7 +595,7 @@ number of other properties. The "type" field contains the fully-qualified
Protobuf message name as a UTF-8 string, and the "value" field contains
unpadded, base64-encoded binary Protobuf data. For readability on the wire,
server implementations may also serialize the detail to JSON and include the
resulting object under the "debug" key. Clients must not depend on data in the
resulting value under the "debug" key. Clients must not depend on data in the
"debug" key when deserializing details.

```json
Expand All @@ -606,7 +606,7 @@ resulting object under the "debug" key. Clients must not depend on data in the
{
"type": "google.rpc.RetryInfo",
"value": "CgIIPA",
"debug": {"retryDelay": "30s"},
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤦🏽‍♂️

"debug": {"retryDelay": "30s"}
}
]
}
Expand Down