es/v2: Remove "Common errors" #219
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Timo Stamm <[email protected]>
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
smaye81
approved these changes
Oct 30, 2024
docs/faq.md
Outdated
Comment on lines
389
to
392
| One specific gotcha to be aware of involves a new header `Connect-Protocol-Version`. With the [v0.6.0 release](https://github.com/connectrpc/connect-es/releases/tag/v0.6.0) | ||
| of `@connectrpc/connect-web`, this header was added to all requests sent via the library. As a result, Connect clients | ||
| that were working prior may start experiencing CORS errors upon upgrading to `v0.6.0`. Note that this also only affects | ||
| Connect traffic. gRPC-Web traffic is unaffected. |
There was a problem hiding this comment.
I'm wondering if this is even worth mentioning any more. We moved to @connectrpc after v0.13.0 and this predates even that by at least 7 releases. I'm sure people are still downloading this out in the wild, but is it worth the extra FAQ noise?
There was a problem hiding this comment.
True. There are only ~250 weekly downloads for < v0.6.0, and we link to the CORS docs from other FAQs. Updated.
Signed-off-by: Timo Stamm <[email protected]>
timostamm
changed the title
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The page Connect for Web / Common errors only explains a single common error: Failed CORS requests when updating to the v0.6.0 release of
@connectrpc/connect-web. This release is nearly two years old, so I don't think it's a common error anymore. This moves the content to the FAQ.