refactor(types): improve type of custodian icon url (#778)

consensys-vertical-apps · Jul 23, 2024 · 3efcf66 · 3efcf66
1 parent deafdd5
commit 3efcf66
Show file tree

Hide file tree

Showing 6 changed files with 9 additions and 9 deletions.
diff --git a/packages/custodyKeyring/src/custodianTypes/bitgo/BitgoCustodyKeyring.ts b/packages/custodyKeyring/src/custodianTypes/bitgo/BitgoCustodyKeyring.ts
@@ -21,7 +21,7 @@ export class BitgoCustodyKeyring extends CustodyKeyring {
     displayName: "BitGo",
     apiUrl: "https://app.bitgo.com/defi/v2",
     imgSrc: "https://dashboard.metamask-institutional.io/custodian-icons/bitgo-icon.svg",
-    icon: "https://dashboard.metamask-institutional.io/custodian-icons/bitgo-icon.svg",
+    iconUrl: "https://dashboard.metamask-institutional.io/custodian-icons/bitgo-icon.svg",
     website: "https://www.bitgo.com",
     onboardingUrl: "https://www.bitgo.com",
     envName: "bitgo",

diff --git a/packages/custodyKeyring/src/custodianTypes/cactus/CactusCustodyKeyring.ts b/packages/custodyKeyring/src/custodianTypes/cactus/CactusCustodyKeyring.ts
@@ -20,7 +20,7 @@ export class CactusCustodyKeyring extends CustodyKeyring {
     displayName: "Cactus Custody",
     apiUrl: "https://api.mycactus.com/custody/v1/mmi-api",
     imgSrc: "https://dashboard.metamask-institutional.io/custodian-icons/cactus-icon.svg",
-    icon: "https://dashboard.metamask-institutional.io/custodian-icons/cactus-icon.svg",
+    iconUrl: "https://dashboard.metamask-institutional.io/custodian-icons/cactus-icon.svg",
     website: "https://www.mycactus.com",
     onboardingUrl: "https://www.mycactus.com",
     envName: "cactus",

diff --git a/packages/custodyKeyring/src/custodianTypes/eca3/ECA3CustodyKeyring.ts b/packages/custodyKeyring/src/custodianTypes/eca3/ECA3CustodyKeyring.ts
@@ -24,7 +24,7 @@ export class ECA3CustodyKeyring extends CustodyKeyring {
     displayName: "ECA3",
     apiUrl: "https://neptune-custody.codefi.network/eth",
     imgSrc: "https://backend.vistan-brillen.de/storage/files/images/marken/changeme/header/changeme-logo-header.jpg",
-    icon: "https://backend.vistan-brillen.de/storage/files/images/marken/changeme/header/changeme-logo-header.jpg",
+    iconUrl: "https://backend.vistan-brillen.de/storage/files/images/marken/changeme/header/changeme-logo-header.jpg",
     website: "https://neptune-custody-ui.metamask-institutional.io/",
     onboardingUrl: "https://neptune-custody-ui.metamask-institutional.io/",
     envName: "neptune-custody",

diff --git a/packages/custodyKeyring/src/custodianTypes/index.ts b/packages/custodyKeyring/src/custodianTypes/index.ts
@@ -11,7 +11,7 @@ export const CUSTODIAN_TYPES: { [key: string]: ICustodianType } = {
     displayName: "Cactus Custody",
     apiUrl: "https://api.mycactus.com/custody/v1/mmi-api",
     imgSrc: "https://dashboard.metamask-institutional.io/custodian-icons/cactus-icon.svg",
-    icon: "https://dashboard.metamask-institutional.io/custodian-icons/cactus-icon.svg",
+    iconUrl: "https://dashboard.metamask-institutional.io/custodian-icons/cactus-icon.svg",
     website: "https://www.mycactus.com",
     onboardingUrl: "https://www.mycactus.com",
     envName: "cactus",
@@ -35,7 +35,7 @@ export const CUSTODIAN_TYPES: { [key: string]: ICustodianType } = {
     displayName: "BitGo",
     apiUrl: "https://app.bitgo.com/defi/v2",
     imgSrc: "https://dashboard.metamask-institutional.io/custodian-icons/bitgo-icon.svg",
-    icon: "https://dashboard.metamask-institutional.io/custodian-icons/bitgo-icon.svg",
+    iconUrl: "https://dashboard.metamask-institutional.io/custodian-icons/bitgo-icon.svg",
     website: "https://www.bitgo.com",
     onboardingUrl: "https://www.bitgo.com",
     envName: "bitgo",
@@ -65,7 +65,7 @@ export const CUSTODIAN_TYPES: { [key: string]: ICustodianType } = {
     displayName: "JSON-RPC",
     apiUrl: "https://saturn-custody.codefi.network/eth",
     imgSrc: "https://saturn-custody-ui.metamask-institutional.io/saturn.svg",
-    icon: "https://saturn-custody-ui.metamask-institutional.io/saturn.svg",
+    iconUrl: "https://saturn-custody-ui.metamask-institutional.io/saturn.svg",
     website: "https://saturn-custody-ui.metamask-institutional.io/",
     onboardingUrl: "https://saturn-custody-ui.metamask-institutional.io/",
     envName: "saturn-prod",
@@ -82,7 +82,7 @@ export const CUSTODIAN_TYPES: { [key: string]: ICustodianType } = {
     displayName: "ECA3",
     apiUrl: "https://neptune-custody.codefi.network/eth",
     imgSrc: "https://backend.vistan-brillen.de/storage/files/images/marken/changeme/header/changeme-logo-header.jpg",
-    icon: "https://backend.vistan-brillen.de/storage/files/images/marken/changeme/header/changeme-logo-header.jpg",
+    iconUrl: "https://backend.vistan-brillen.de/storage/files/images/marken/changeme/header/changeme-logo-header.jpg",
     website: "https://neptune-custody-ui.metamask-institutional.io/",
     onboardingUrl: "https://neptune-custody-ui.metamask-institutional.io/",
     envName: "neptune-custody",

diff --git a/packages/custodyKeyring/src/custodianTypes/json-rpc/JsonRpcCustodyKeyring.ts b/packages/custodyKeyring/src/custodianTypes/json-rpc/JsonRpcCustodyKeyring.ts
@@ -24,7 +24,7 @@ export class JsonRpcCustodyKeyring extends CustodyKeyring {
     displayName: "JSON-RPC",
     apiUrl: "https://saturn-custody.codefi.network/eth",
     imgSrc: "https://saturn-custody-ui.metamask-institutional.io/saturn.svg",
-    icon: "https://saturn-custody-ui.metamask-institutional.io/saturn.svg",
+    iconUrl: "https://saturn-custody-ui.metamask-institutional.io/saturn.svg",
     website: "https://saturn-custody-ui.metamask-institutional.io/",
     onboardingUrl: "https://saturn-custody-ui.metamask-institutional.io/",
     envName: "saturn-prod",

diff --git a/packages/types/src/ICustodian.ts b/packages/types/src/ICustodian.ts
@@ -10,7 +10,7 @@ export interface ICustodianType {
   apiVersion?: string;
   custodianPublishesTransaction?: boolean;
   imgSrc: string;
-  icon: string;
+  iconUrl: string;
   website: string;
   onboardingUrl: string;
   envName: string;