Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): @metamask/obs-store@^8.0.0->^9.0.0 #719

Merged
merged 2 commits into from
Jun 19, 2024

Conversation

legobeat
Copy link
Contributor

@legobeat legobeat commented May 14, 2024

Description

Update dependency @metamask/obs-store from v8 to v9 in using packages.

Motivation and Context

v8 is implemented towards legacy stream libraries. v9 updates to readable-stream v3.

This is part of consolidating streams APIs in extension.

Related

Corresponding update in extension:

How Has This Been Tested?

Not at all. Any help here appreciated.

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@legobeat legobeat marked this pull request as ready for review May 14, 2024 23:40
@legobeat legobeat changed the title deps: @metamask/obs-store@^8.0.0->^9.0.0 chore(deps): @metamask/obs-store@^8.0.0->^9.0.0 May 15, 2024
@legobeat
Copy link
Contributor Author

@albertolive I can haz CI tests run? :)

@legobeat
Copy link
Contributor Author

On Node.js v19:

error @metamask/[email protected]: The engine "node" is incompatible with this module. Expected version "^14.21 || ^16.20 || ^18.16 || >=20". Got "19.9.0"

@zone-live zone-live merged commit 3ce5fd7 into consensys-vertical-apps:main Jun 19, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants