Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix npm publish node version #847

Merged
merged 1 commit into from
Oct 15, 2024
Merged

fix: fix npm publish node version #847

merged 1 commit into from
Oct 15, 2024

Conversation

albertolive
Copy link
Collaborator

@albertolive albertolive commented Oct 15, 2024

Description

Our current CI/CD pipeline is failing due to a version incompatibility between our specified Node.js version and the requirements of the Lerna package. Specifically, Lerna requires Node.js version 18.0.0 or higher, but our workflow is currently using Node.js 16.20.2.

This pull request updates our GitHub Actions workflow and package.json to use Node.js version 18, ensuring compatibility with the latest version of Lerna.

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@albertolive albertolive merged commit 29e33c4 into main Oct 15, 2024
5 checks passed
@albertolive albertolive deleted the fix-publish-job branch October 15, 2024 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants