Initial work to support dynamic multiple CNI configurations #113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MikeZappa87
force-pushed
the
issue/multi-network-support
branch
3 times, most recently
from
87621fe to
196f34f
Compare
AkihiroSuda
reviewed
Aug 2, 2023
|
Please squash commits |
MikeZappa87
force-pushed
the
issue/multi-network-support
branch
from
cdadd4a to
46c60c5
Compare
|
I am going to run a few more tests with this code in containerd. As of now all tests have been successful. |
AkihiroSuda
approved these changes
Aug 3, 2023
MikeZappa87
force-pushed
the
issue/multi-network-support
branch
from
985ec85 to
e4fd289
Compare
Signed-off-by: Michael Zappa <[email protected]>
MikeZappa87
force-pushed
the
issue/multi-network-support
branch
from
1d661df to
89f6935
Compare
|
@AkihiroSuda I made a few updates. I have squashed the commits. |
MikeZappa87
commented
Nov 23, 2024
| @@ -83,6 +89,11 @@ type libcni struct { | |||
| sync.RWMutex | |||
| } | |||
|
|
|||
| type NetworkInterface struct { | |||
There was a problem hiding this comment.
I am thinking through this type. It works in the current however give me some time to debate. If anyone likes the current state lmk
MikeZappa87
commented
Nov 23, 2024
| name := "" | ||
| for _, v := range networkNames { | ||
| if net, ok := config[v.NetworkName]; ok { | ||
| if v.InterfaceName == "" { |
There was a problem hiding this comment.
What if a network has two or more interfaces?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will enable dynamic multiple cni networks to be executed. A large effort is happening in the K8s ecosystem referred to as 'Multi-Network' this will support that. Multiple PR's will follow in containerd to upddate go-cni and provide the code to enable this in the cri containerd plugin.