Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support loop-dev mount in mount_rootfs #305

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

zzzzzzzzzy9
Copy link
Contributor

support loop-dev mount in mount_rootfs

@github-actions github-actions bot added the C-shim Containerd shim label Aug 1, 2024
@zzzzzzzzzy9 zzzzzzzzzy9 force-pushed the loop-dev branch 2 times, most recently from 1fd0def to b69cf1c Compare August 1, 2024 16:48
@@ -615,6 +690,164 @@ pub fn mount_rootfs(
Err(Error::Unimplemented("start".to_string()))
}

#[cfg(target_os = "linux")]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if we should move linux specific code to mount_linux.rs ?
So we don't have to specify target for each function.

Copy link
Member

@mxpv mxpv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It'd great to have some unit tests to cover loop dev functionality.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-shim Containerd shim needs update
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants