Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

install: Support gathering more info for host root (including LVM) #384

Merged
merged 1 commit into from
Mar 11, 2024

Conversation

cgwalters
Copy link
Collaborator

Builds on top of #382

install: Support gathering more info for host root (including LVM)

Teach install to-existing-root how to gather kernel arguments
and information we need from /proc/cmdline (such as rd.lvm.lv).
In this case too, we need to adjust the args to use -v /dev:/dev
because we need the stuff udev generates from the real host root.

With these things together, I can do a bootc alongside install
targeting a Fedora Server instance.

Closes: #175
Signed-off-by: Colin Walters [email protected]


Copy link

openshift-ci bot commented Mar 8, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@github-actions github-actions bot added the area/install Issues related to `bootc install` label Mar 8, 2024
@cgwalters cgwalters marked this pull request as ready for review March 8, 2024 22:58
@cgwalters
Copy link
Collaborator Author

I had this as draft as it was building on the other PR, but maybe it's simpler to just merge them together now.

Teach `install to-existing-root` how to gather kernel arguments
and information we need from `/proc/cmdline` (such as `rd.lvm.lv`).
In this case too, we need to adjust the args to use `-v /dev:/dev`
because we need the stuff udev generates from the real host root.

With these things together, I can do a bootc alongside install
targeting a Fedora Server instance.

Closes: containers#175
Signed-off-by: Colin Walters <[email protected]>
@cgwalters
Copy link
Collaborator Author

/retest

Copy link
Member

@jmarrero jmarrero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jmarrero jmarrero merged commit e7a93c2 into containers:main Mar 11, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/install Issues related to `bootc install`
Projects
None yet
Development

Successfully merging this pull request may close these issues.

install-to-filesystem does not work when targeting LVM
2 participants