lib: Verify mode values #315
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This will textually (but not logically) conflict with #314 due to dump file addition; let's merge that first. |
alexlarsson
approved these changes
Aug 19, 2024
|
Hmm, this looks good, but seems to break the CI... |
Today, `lcfs_node_set_mode` happily accepts any `mode_t` aka uint32 value and basically dumps it into the erofs inode. I accidentally stumbled over this when I forgot that a regular file needs `S_IFREG` in the mode bits in the dump file, but at least `fsck.erofs` does notice this. Signed-off-by: Colin Walters <[email protected]>
cgwalters
force-pushed
the
detect-invalid-mode
branch
from
778de61
to
9fa7dab
Compare
OK yeah, we need to skip checking the mode for hardlinks as it's not meaningful; done. |
We were writing to the sourcedir. Signed-off-by: Colin Walters <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Today,
lcfs_node_set_modehappily accepts anymode_taka uint32 value and basically dumps it into the erofs inode. I accidentally stumbled over this when I forgot that a regular file needsS_IFREGin the mode bits in the dump file, but at leastfsck.erofsdoes notice this.