e2e: skip long running tests by default. #373
Conversation
klihub
changed the title
|
@askervin @fmuyassarov @kad @pfl PTAL. |
There was a problem hiding this comment.
LGTM.
The only improvement that I could come up with is printing something like "SKIP $TEST_DIR (long_tests=no)", as I can imagine myself wondering after few months why ./run_tests.sh doesn't do anything.
But this is a comment rather than a request because "Running tests matching:..." already should reveal what is going on. And I can imagine also finding the explanation soon enough from there. :D
Skip time consuming tests by default. Run them if skip_long_tests=no is set. A test is assumed to be time consuming if the test directory matches any of the *long*, *fuzz*, or *stress* patterns. Signed-off-by: Krisztian Litkey <[email protected]>
klihub
force-pushed
the
devel/skip-loooong-tests-by-default
branch
from
0b4ab32
to
fc52b55
Compare
Good point. I'm think I myself would not realize after a week why long tests are not run at all. Updated, adding printouts when we skip tests. I also inverted the control variable name and semantics to |
klihub
changed the title
Skip tests matching *long*, *fuzz*, or *stress* by default. Run them when
skip_long_tests=nois set.