feat: set slower backoff for current context

Signed-off-by: Philippe Martin <[email protected]>

packages/main/src/plugin/kubernetes/backoff.spec.ts

@@ -21,7 +21,7 @@ import { expect, test } from 'vitest';
 import { Backoff } from './backoff.js';
 
 test('backoff increment and limit without jitter', () => {
-  const backoff = new Backoff(100, 500, 0);
+  const backoff = new Backoff(100, 2, 500, 0);
   expect(backoff.get()).toEqual(100);
   expect(backoff.get()).toEqual(200);
   expect(backoff.get()).toEqual(400);
@@ -32,15 +32,15 @@ test('backoff increment and limit without jitter', () => {
 test('backoff with jitter', () => {
   let jitterFound = false;
   let base = 100;
-  let backoff: Backoff = new Backoff(base, 500, 10);
+  let backoff: Backoff = new Backoff(base, 2, 500, 10);
   // run several tests, as we cannot rely on a single one due to the random nature
   for (let i = 0; i < 10; i++) {
     const value = backoff.get();
     expect(value).not.toBeLessThan(base);
     expect(value).toBeLessThan(base * 1.1);
     if (value === base) {
       // this can happen, try again
-      backoff = new Backoff(base, 500, 10);
+      backoff = new Backoff(base, 2, 500, 10);
       continue;
     }
     jitterFound = true;
@@ -54,7 +54,7 @@ test('backoff with jitter', () => {
 });
 
 test('backoff reset', () => {
-  const backoff = new Backoff(100, 500, 0);
+  const backoff = new Backoff(100, 2, 500, 0);
   expect(backoff.get()).toBe(100);
   expect(backoff.get()).toBe(200);
   expect(backoff.get()).toBe(400);

packages/main/src/plugin/kubernetes/backoff.ts

@@ -20,6 +20,7 @@ export class Backoff {
   private readonly initial: number;
   constructor(
     public value: number,
+    public multiplier: number,
     private readonly max: number,
     private readonly jitter: number,
   ) {
@@ -29,7 +30,7 @@ export class Backoff {
   get(): number {
     const current = this.value;
     if (this.value < this.max) {
-      this.value *= 2;
+      this.value *= this.multiplier;
       this.value += this.getJitter();
     }
     return current;

packages/main/src/plugin/kubernetes/contexts-constants.ts

@@ -21,8 +21,14 @@
 export const connectTimeout = 1000;
 // initial delay between two connection attempts
 export const backoffInitialValue = 1000;
+// the backoff will be multiplied by this number every time
+export const backoffMultiplier = 2.0;
+// the backoff will be multiplied by this number every time for current context
+export const backoffMultiplierCurrentContext = 1.2;
 // maximum delay between two connection attempts
 export const backoffLimit = 60_000;
+// maximum delay between two connection attempts for current context
+export const backoffLimitCurrentContext = 10_000;
 // jitter to add to the delay between two connection attempts
 export const backoffJitter = 300;
 // the time to wait for any update on the data to dispatch before to send it

packages/main/src/plugin/kubernetes/contexts-manager.spec.ts

@@ -96,7 +96,10 @@ vi.mock('./contexts-constants.js', () => {
   return {
     connectTimeout: 1,
     backoffInitialValue: 10000,
+    backoffMultiplier: 2.0,
+    backoffMultiplierCurrentContext: 1.2,
     backoffLimit: 1000,
+    backoffLimitCurrentContext: 1000,
     backoffJitter: 0,
     dispatchTimeout: 1,
   };

packages/main/src/plugin/kubernetes/contexts-manager.ts

@@ -58,7 +58,15 @@ import type { V1Route } from '/@api/openshift-types.js';
 
 import type { ApiSenderType } from '../api.js';
 import { Backoff } from './backoff.js';
-import { backoffInitialValue, backoffJitter, backoffLimit, connectTimeout } from './contexts-constants.js';
+import {
+  backoffInitialValue,
+  backoffJitter,
+  backoffLimit,
+  backoffLimitCurrentContext,
+  backoffMultiplier,
+  backoffMultiplierCurrentContext,
+  connectTimeout,
+} from './contexts-constants.js';
 import { ContextsInformersRegistry } from './contexts-informers-registry.js';
 import type { ContextInternalState } from './contexts-states-registry.js';
 import { ContextsStatesRegistry, dispatchAllResources, isSecondaryResourceName } from './contexts-states-registry.js';
@@ -379,7 +387,7 @@ export class ContextsManager {
       checkReachable: true,
       resource: 'pods',
       timer: timer,
-      backoff: new Backoff(backoffInitialValue, backoffLimit, backoffJitter),
+      backoff: this.getBackoffForContext(context.name),
       connectionDelay: connectionDelay,
       onAdd: obj => {
         this.states.setStateAndDispatch(context.name, {
@@ -447,7 +455,7 @@ export class ContextsManager {
     return this.createInformer<V1Deployment>(kc, context, path, listFn, {
       resource: 'deployments',
       timer: timer,
-      backoff: new Backoff(backoffInitialValue, backoffLimit, backoffJitter),
+      backoff: this.getBackoffForContext(context.name),
       connectionDelay: connectionDelay,
       onAdd: obj => {
         this.states.setStateAndDispatch(context.name, {
@@ -494,7 +502,7 @@ export class ContextsManager {
     return this.createInformer<V1ConfigMap>(kc, context, path, listFn, {
       resource: 'configmaps',
       timer: timer,
-      backoff: new Backoff(backoffInitialValue, backoffLimit, backoffJitter),
+      backoff: this.getBackoffForContext(context.name),
       connectionDelay: connectionDelay,
       onAdd: obj => {
         this.states.setStateAndDispatch(context.name, {
@@ -536,7 +544,7 @@ export class ContextsManager {
     return this.createInformer<V1Secret>(kc, context, path, listFn, {
       resource: 'secrets',
       timer: timer,
-      backoff: new Backoff(backoffInitialValue, backoffLimit, backoffJitter),
+      backoff: this.getBackoffForContext(context.name),
       connectionDelay: connectionDelay,
       onAdd: obj => {
         this.states.setStateAndDispatch(context.name, {
@@ -581,7 +589,7 @@ export class ContextsManager {
     return this.createInformer<V1PersistentVolumeClaim>(kc, context, path, listFn, {
       resource: 'persistentvolumeclaims',
       timer: timer,
-      backoff: new Backoff(backoffInitialValue, backoffLimit, backoffJitter),
+      backoff: this.getBackoffForContext(context.name),
       connectionDelay: connectionDelay,
       onAdd: obj => {
         this.states.setStateAndDispatch(context.name, {
@@ -625,7 +633,7 @@ export class ContextsManager {
     return this.createInformer<V1Node>(kc, context, path, listFn, {
       resource: 'nodes',
       timer: timer,
-      backoff: new Backoff(backoffInitialValue, backoffLimit, backoffJitter),
+      backoff: this.getBackoffForContext(context.name),
       connectionDelay: connectionDelay,
       onAdd: obj => {
         this.states.setStateAndDispatch(context.name, {
@@ -665,7 +673,7 @@ export class ContextsManager {
     return this.createInformer<V1Service>(kc, context, path, listFn, {
       resource: 'services',
       timer: timer,
-      backoff: new Backoff(backoffInitialValue, backoffLimit, backoffJitter),
+      backoff: this.getBackoffForContext(context.name),
       connectionDelay: connectionDelay,
       onAdd: obj => {
         this.states.setStateAndDispatch(context.name, {
@@ -705,7 +713,7 @@ export class ContextsManager {
     return this.createInformer<V1Ingress>(kc, context, path, listFn, {
       resource: 'ingresses',
       timer: timer,
-      backoff: new Backoff(backoffInitialValue, backoffLimit, backoffJitter),
+      backoff: this.getBackoffForContext(context.name),
       connectionDelay: connectionDelay,
       onAdd: obj => {
         this.states.setStateAndDispatch(context.name, {
@@ -751,7 +759,7 @@ export class ContextsManager {
     return this.createInformer<V1Route>(kc, context, path, listFn, {
       resource: 'routes',
       timer: timer,
-      backoff: new Backoff(backoffInitialValue, backoffLimit, backoffJitter),
+      backoff: this.getBackoffForContext(context.name),
       connectionDelay: connectionDelay,
       onAdd: obj => {
         this.states.setStateAndDispatch(context.name, {
@@ -968,4 +976,17 @@ export class ContextsManager {
       clearTimeout(timer);
     }
   }
+
+  private getBackoffForContext(contextName: string): Backoff {
+    if (contextName === this.kubeConfig.currentContext) {
+      return new Backoff(
+        backoffInitialValue,
+        backoffMultiplierCurrentContext,
+        backoffLimitCurrentContext,
+        backoffJitter,
+      );
+    } else {
+      return new Backoff(backoffInitialValue, backoffMultiplier, backoffLimit, backoffJitter);
+    }
+  }
 }