chore: fix svelte 5 deprecation warning #9331
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes containers#9313. Signed-off-by: Tim deBoer <[email protected]>
deboer-tim
requested review from
jeffmaury,
axel7083 and
SoniaSandler
and removed request for
a team
|
there is a typecheck failure then |
jeffmaury
requested changes
Oct 11, 2024
|
Weirdly enough we need to remove the following lines Note sure if they are important ? But removing them fix the svelte-check on my machine |
|
I haven't tried yet, but I'd expect removing that would break reactivity for actions, e.g. if you click start, the icon button on the left wouldn't change. |
It does, I've tried it, and it seems to work fine |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Replaces code to remove deprecation warning.
Screenshot / video of UI
N/A
What issues does this PR fix or reference?
Fixes #9313.
How to test this PR?
PR checks.