Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: call onUpdate callback if configuration is updated programmatically #9366

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

benoitf
Copy link
Collaborator

@benoitf benoitf commented Oct 14, 2024

What does this PR do?

Fix the fact that the emitter was not called

Screenshot / video of UI

What issues does this PR fix or reference?

fixes #9194

How to test this PR?

  • Tests are covering the bug fix or the new feature

@benoitf benoitf requested a review from a team as a code owner October 14, 2024 14:07
@benoitf benoitf requested review from jeffmaury, cdrage and deboer-tim and removed request for a team October 14, 2024 14:07
Copy link
Contributor

@axel7083 axel7083 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jeffmaury jeffmaury changed the title fix: call onUpdate callack if configuration is updated programmatically fix: call onUpdate callback if configuration is updated programmatically Oct 16, 2024
Copy link
Contributor

@jeffmaury jeffmaury left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Configuration change initiated by extension API does not send update event
3 participants