feat: make Kubernetes informers cancellable #9411
Open
+129
−27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Philippe Martin <[email protected]>
Signed-off-by: Philippe Martin <[email protected]>
feloy
requested review from
cdrage,
deboer-tim and
axel7083
and removed request for
a team
axel7083
reviewed
Oct 16, 2024
axel7083
reviewed
Oct 16, 2024
| @@ -364,7 +366,7 @@ export class ContextsManager { | |||
| }; | |||
| } | |||
|
|
|||
| private createPodInformer(kc: KubeConfig, namespace: string, context: KubeContext): Informer<V1Pod> { | |||
| private createPodInformer(kc: KubeConfig, namespace: string, context: KubeContext): CancellableInformer { | |||
There was a problem hiding this comment.
Why are we losing the generic type, is it important ?
There was a problem hiding this comment.
I'll check again, does it does not seem to be useful
There was a problem hiding this comment.
I don't think so:
The V1Pod is necessary when calling this.createInformer<V1Pod>, to have he onAdd and other options have the matching type. But the result of createPodInformer is stored in an Informer<KubernetesObject>; the specific type is never used on this side.
Signed-off-by: Philippe Martin <[email protected]>
benoitf
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Philippe Martin [email protected]
What does this PR do?
For #6114 , we will need to restart the informers every time we change the current context, to change their backoff configuration.
Working on this, I realized that the informers were not correctly stopped when not necessary anymore.
This PR makes the informers cancellable, so we can make them stop their infinite loop of retries.
What issues does this PR fix or reference?
Part of #6114
How to test this PR?