-
Notifications
You must be signed in to change notification settings - Fork 298
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(ui): layers explorer margin issue #9412
fix(ui): layers explorer margin issue #9412
Conversation
Signed-off-by: axel7083 <[email protected]>
Signed-off-by: axel7083 <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for the fix
Signed-off-by: axel7083 <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wondering why we're kind using a flat display to represent a tree
Like why not using ul/li or parent/child ?
I mean, why there is a always a bigger shift from the left
I would expect that we only add a child that has always the same shift but as we're imbricating children, it does the tree /shift
I remember trying this solution, but also encountering some other problem (sorry, cannot remember which one) |
my proposal is to merge this as it fixes easily the issue, and we can open a technical issue on this one, is that okay with you @benoitf ? |
sure I'm not requesting changes |
What does this PR do?
Avoid using runtime classes of tailwindcss, since tailwindcss do not generate classes if do not exists at compile time1
Screenshot / video of UI
What issues does this PR fix or reference?
Fixes #9410
How to test this PR?
Footnotes
https://stackoverflow.com/questions/69687530/dynamically-build-classnames-in-tailwindcss ↩