Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui): layers explorer margin issue #9412

Merged
merged 3 commits into from
Oct 17, 2024

Conversation

axel7083
Copy link
Contributor

What does this PR do?

Avoid using runtime classes of tailwindcss, since tailwindcss do not generate classes if do not exists at compile time1

Screenshot / video of UI

Before After
image image

What issues does this PR fix or reference?

Fixes #9410

How to test this PR?

  • Tests are covering the bug fix or the new feature

Footnotes

  1. https://stackoverflow.com/questions/69687530/dynamically-build-classnames-in-tailwindcss

@axel7083 axel7083 requested review from benoitf and a team as code owners October 16, 2024 14:37
@axel7083 axel7083 requested review from dgolovin, jeffmaury, SoniaSandler and feloy and removed request for a team October 16, 2024 14:37
Copy link
Contributor

@feloy feloy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the fix

packages/renderer/src/lib/image/FilesystemLayerView.svelte Outdated Show resolved Hide resolved
Signed-off-by: axel7083 <[email protected]>
Copy link
Collaborator

@benoitf benoitf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wondering why we're kind using a flat display to represent a tree

Like why not using ul/li or parent/child ?

I mean, why there is a always a bigger shift from the left
I would expect that we only add a child that has always the same shift but as we're imbricating children, it does the tree /shift

@feloy
Copy link
Contributor

feloy commented Oct 17, 2024

wondering why we're kind using a flat display to represent a tree

Like why not using ul/li or parent/child ?

I mean, why there is a always a bigger shift from the left I would expect that we only add a child that has always the same shift but as we're imbricating children, it does the tree /shift

I remember trying this solution, but also encountering some other problem (sorry, cannot remember which one)

@axel7083
Copy link
Contributor Author

Like why not using ul/li or parent/child ?

my proposal is to merge this as it fixes easily the issue, and we can open a technical issue on this one, is that okay with you @benoitf ?

@benoitf
Copy link
Collaborator

benoitf commented Oct 17, 2024

sure I'm not requesting changes

@axel7083 axel7083 merged commit 16983a4 into containers:main Oct 17, 2024
15 checks passed
@podman-desktop-bot podman-desktop-bot added this to the 1.14.0 milestone Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug(layer explorer): tree issue
4 participants