Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hardcoded colors #9414

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

Conversation

SoniaSandler
Copy link
Contributor

@SoniaSandler SoniaSandler commented Oct 16, 2024

What does this PR do?

(Will be split into multiple PR, no need to review this one)
Updates any bg- and text- hardcoded colors to use the color registry

Screenshot / video of UI

What issues does this PR fix or reference?

Closes #9080

How to test this PR?

  • Tests are covering the bug fix or the new feature

@deboer-tim
Copy link
Contributor

This is great work, but I'm really hoping you break this up into several areas/PRs to make review & merging easier. 🙂

@SoniaSandler
Copy link
Contributor Author

@deboer-tim I'll do it, I just followed Philippe's list, so it's a lot 😅.
I'm not sure what to do about:

  • packages/renderer/src/lib/dialogs/CommandPalette.svelte
  • packages/renderer/src/lib/dialogs/CustomPick.svelte
  • packages/renderer/src/lib/dialogs/QuickPickInput.svelte
    since I can't find how to view the components. Is there a way to do it?

@benoitf
Copy link
Collaborator

benoitf commented Oct 16, 2024

packages/renderer/src/lib/dialogs/CommandPalette.svelte

press F1 key

@benoitf
Copy link
Collaborator

benoitf commented Oct 16, 2024

packages/renderer/src/lib/dialogs/QuickPickInput.svelte

click in bottom left on 'the kubernetes context'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hardcoded colors values
3 participants