fix: bump axios 1.x [PHX-2740] #1967
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcolink
force-pushed
the
chore/bump-axios-1.x
branch
2 times, most recently
from
b038ba4
to
3130b18
Compare
andreascful
reviewed
Jul 20, 2023
| @@ -6,4 +6,7 @@ module.exports = { | |||
| globals: { | |||
| __VERSION__: require('./package.json').version, | |||
| }, | |||
| moduleNameMapper: { | |||
| axios: 'axios/dist/node/axios.cjs', | |||
There was a problem hiding this comment.
Just curious: What makes this change necessary?
There was a problem hiding this comment.
axios is now published as ESM & CJS - after updating it - jest failed. This fixes it again.
andreascful
approved these changes
Jul 20, 2023
marcolink
force-pushed
the
chore/bump-axios-1.x
branch
from
db7c653
to
09af8f4
Compare
|
🎉 This PR is included in version 10.4.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Major bump for
axiosandcontentful-sdk-core