Remove CELERY_BROKER_URL in favor of REDIS_URL #4861
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
foarsitter
force-pushed
the
remove_celery_broker_url
branch
from
557856b
to
641d833
Compare
This was referenced Aug 27, 2024
foarsitter
requested review from
browniebroke
and removed request for
browniebroke
foarsitter
force-pushed
the
remove_celery_broker_url
branch
from
641d833
to
4709a30
Compare
Comment on lines
-58
to
-59
| # Optional: set broker URL if using Celery | ||
| $ export CELERY_BROKER_URL=redis://localhost:6379/0 |
There was a problem hiding this comment.
Should this tell people to set the REDIS_URL instead?
Comment on lines
-128
to
-130
| {%- if cookiecutter.use_celery == "y" %} | ||
| CELERY_BROKER_URL="" \ | ||
| {%- endif %} |
There was a problem hiding this comment.
I think that was required because the env variable has no default in the settings, which is still the case with REDIS_URL
Comment on lines
-8
to
-11
| {% if cookiecutter.use_celery == 'y' %} | ||
| # N.B. If only .env files supported variable expansion... | ||
| export CELERY_BROKER_URL="${REDIS_URL}" | ||
| {% endif %} |
Comment on lines
-29
to
-31
| {%- if cookiecutter.use_celery == 'y' %} | ||
| os.environ["CELERY_BROKER_URL"] = os.getenv("REDIS_URL", "redis://redis:6379") | ||
| {%- endif %} |
There was a problem hiding this comment.
This one might be still be required too...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #4811 this is how it looks like to remove
CELERY_BROKER_URL.Considering the amount of deletions, this looks like the right path.