Remove DATABASE_URL where possible #4862
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
foarsitter
force-pushed
the
remove_database_url
branch
from
2b74919 to
7d899c2
Compare
foarsitter
changed the title
foarsitter
requested review from
browniebroke
and removed request for
browniebroke
foarsitter
force-pushed
the
remove_database_url
branch
from
7d899c2 to
d275ac2
Compare
Co-authored-by: Bruno Alla <[email protected]>
# Conflicts:
# docs/2-local-development/developing-locally.rst
# {{cookiecutter.project_slug}}/compose/production/django/Dockerfile
| POSTGRES_USER: 'postgres' | ||
| POSTGRES_PASSWORD: 'postgres' | ||
| POSTGRES_DB: 'postgres' | ||
| POSTGRES_HOST: 'postgres' |
There was a problem hiding this comment.
I think the host used to be localhost... Was it intentional or should we keep that?
Suggested change
| POSTGRES_HOST: 'postgres' | |
| POSTGRES_HOST: 'localhost' |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an attempt the remove
DATABASE_URLenvironment variable.The only use case where
DATABASE_URLis required is when an application is hosted on heroku.