Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Swift Package Manager #2

Merged
merged 2 commits into from
Jul 25, 2023
Merged

Support Swift Package Manager #2

merged 2 commits into from
Jul 25, 2023

Conversation

liamnichols
Copy link
Member

The original ios-twitter-image-pipeline repository supported CocoaPods but did not offer support for SPM. To support SPM, we need to do a few things:

  1. Restructure target directories to place public headers in an includes directory in order to automatically generate a module map
  2. Use XCFramework distributions of WebP (Use xcframework distribution of WebP #1)
  3. Correct imports/includes
  4. Rework test bundles

In this Pull Request, I do all of the above and also update WebP to 1.2.4 (was 1.2.2).

Note: At the same time, I deleted the original xcodeproj which also housed sample apps. I've moved the code into the Project dir but I have not restored the project itself. The samples don't work anyway because they relied on the Twitter API, so i'm not going to invest the time in getting them working again.

@liamnichols liamnichols force-pushed the ln/spm branch 5 times, most recently from 8024e5b to 62ed84b Compare July 25, 2023 10:35
@liamnichols liamnichols merged commit 6e81e6c into main Jul 25, 2023
2 checks passed
@liamnichols liamnichols deleted the ln/spm branch July 25, 2023 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant