Fix repository name collision

[ink-splatters]

Two versions of tests/demo/doc/mañana.txt existed in the repository at the same time, each of them with unique filename.

This was possible because of git ill-formed approach utilizing filesystem-dependent filename representations by default.

It's likely that the mentioned file was added twice: both on Linux and macOS, and due to filename encoding differences between the systems, git permitted it.

This PR fixes #1595 by:

• first removing the affected file
• changing faulty git defaults ( basically - enabling UTF-8 support)
• re-adding the file

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (master@ae49a49). Click here to learn what that means.
Report is 2 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff            @@
##             master    #1596   +/-   ##
=========================================
  Coverage          ?   97.28%           
=========================================
  Files             ?       48           
  Lines             ?     4607           
  Branches          ?        0           
=========================================
  Hits              ?     4482           
  Misses            ?      125           
  Partials          ?        0           

Flag	Coverage Δ
unittests	97.28% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[yajo]

Tbh I never liked having that file around. The file is used in a couple of tests:

copier/tests/test_exclude.py

Lines 57 to 75 in 69662e3

	@pytest.mark.xfail(
	condition=platform.system() in {"Darwin", "Windows"},
	reason="OS without proper UTF-8 filesystem.",
	strict=True,
	)
	def test_path_filter(tmp_path_factory: pytest.TempPathFactory) -> None:
	src, dst = map(tmp_path_factory.mktemp, ("src", "dst"))
	file_excluded: Mapping[StrOrPath, bool] = {
	"x.exclude": True,
	"do_not.exclude!": False,
	# dir patterns and their negations
	Path("exclude_dir", "x"): True,
	Path("exclude_dir", "please_copy_me"): False, # no mercy
	Path("not_exclude_dir", "x!"): False,
	# unicode patterns
	"mañana.txt": True,
	"mañana.txt": False,
	"manana.txt": False,
	}

copier/tests/test_copy.py

Line 180 in 69662e3

assert_file(tmp_path, "doc", "mañana.txt")

copier/tests/test_copy.py

Lines 234 to 246 in 69662e3

	@pytest.mark.xfail(
	condition=platform.system() == "Darwin",
	reason="Mac claims to use UTF-8 filesystem, but behaves differently.",
	strict=True,
	)
	def test_exclude_file(tmp_path: Path) -> None:
	print(f"Filesystem encoding is {sys.getfilesystemencoding()}")
	# This file name is b"man\xcc\x83ana.txt".decode()
	render(tmp_path, exclude=["mañana.txt"])
	assert not (tmp_path / "doc" / "mañana.txt").exists()
	# This file name is b"ma\xc3\xb1ana.txt".decode()
	assert (tmp_path / "doc" / "mañana.txt").exists()
	assert (tmp_path / "doc" / "manana.txt").exists()

The tests were skipped on non-linux OS.

I think we should refactor those tests and create the src template in a tmp dir during the test using build_file_tree.

Do you think you could do that?

[yajo]

The most weird thing is that tests still pass, so I guess they were not doing what I thought 🤔