replace spop library #89
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @fionera. Thanks for your contribution. While looking at the code, you have added your own package here. Sadly, there is no license in the code you published. Can you clarify that, please? |
|
Oops yes, let me push a license real quick |
|
Just pushed the LICENSE file. Everything in that repo is licensed under Apache-2.0 :) |
|
Just updated the PR to the current version which contains lots of fixed :) |
|
Will be replaced by another PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #51 this can be used as replacement for the current spop library. I didnt make the code any more fancy, just replaced it quick and dirty