Skip to content
This repository has been archived by the owner on Aug 25, 2021. It is now read-only.

fetch: Inject headers from /usr/lib/os-release #136

Closed
wants to merge 1 commit into from

Conversation

cgwalters
Copy link
Member

Depends: coreos/ignition#889

So that the openshift/machine-config-operator server can dispatch
on them to aid with Ignition spec 3 transitions.

Depends: coreos/ignition#889

So that the openshift/machine-config-operator server can dispatch
on them to aid with Ignition spec 3 transitions.
@cgwalters
Copy link
Member Author

Note that having this actually be useful also depends on dracutdevs/dracut#655

@bgilbert
Copy link
Contributor

So that the openshift/machine-config-operator server can dispatch on them to aid with Ignition spec 3 transitions.

Could you fill in (or provide a reference) why the existing Accept header won't work for this?

@cgwalters
Copy link
Member Author

Could you fill in (or provide a reference) why the existing Accept header won't work for this?

You're right that the existing Accept header is enough for the Ignition transition, I am also trying to add this header to help handle bootimage detection - so we can easily distinguish between e.g. 4.1 and 4.2 bootimages that both Accept: ignition;version=2.0. (In practice since we're not updating those we can't easily distinguish them now, but we can at least distinguish between 4.3 and 4.4)

@darkmuggle
Copy link
Contributor

@cgwalters is this still needed? If so, can you you rebase this over to Ignition itself?

@bgilbert
Copy link
Contributor

Closing this out, since this repository is abandoned. Please reopen against coreos/ignition if still relevant.

@bgilbert bgilbert closed this Aug 12, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants