Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce merge conflicts in VerifyCACerts #475

Merged
merged 1 commit into from
Jul 12, 2023

Conversation

rgithubli
Copy link
Contributor

Backport of corretto/corretto-17@fe7ab0b.

Had to do some syntax changes. E.g.:

public static final Map<String, String> AMAZON_CA_FINGERPRINT_MAP = new HashMap<String, String>()

instead of using

public static final Map<String, String> AMAZON_CA_FINGERPRINT_MAP = new HashMap<>()

due to 8 differences.

Test passed locally:

x64-2 (develop) % /workplace/ruiamzn/github/corretto-8/jtreg/bin/jtreg -va -jdk:/workplace/ruiamzn/github/corretto-8/installers/linux/universal/tar/corretto-build/amazon-corretto-8.382.04.1-linux-x64 \
/workplace/ruiamzn/github/corretto-8/jdk/test/sun/security/lib/cacerts/VerifyCACerts.java

....
TEST RESULT: Passed. Execution successful
...

* Reduce merge conflicts in VerifyCACerts

* Update license for AmazonCACertConstants.java
@rgithubli rgithubli requested a review from mrserb July 12, 2023 22:32
@rgithubli rgithubli merged commit 3c4c9e2 into corretto:develop Jul 12, 2023
29 of 32 checks passed
@rgithubli rgithubli deleted the ca-cert branch July 12, 2023 23:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants