Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create new Intro screen #138

Merged
merged 25 commits into from
Apr 3, 2024
Merged

Conversation

johnarban
Copy link
Contributor

This PR creates a new intro screen for showing where things are on the main view

@patudom
Copy link
Contributor

patudom commented Apr 2, 2024

Even with the shorter text, this was still happening on my phone.
IMG_9820

My above commit is an attempt to push the "close" icon outside the overlay in the corner. I'm not crazy about it because the white x box on blue sky doesn't have quite enough contrast. Black on sky has a bit more contrast, but it felt less associated with the overlay because of the white outline. This is what it looks like on my phone:

IMG_9822

@johnarban, let me know what you think. We can come up with another solution if you don't like this.

@patudom
Copy link
Contributor

patudom commented Apr 2, 2024

Ok, one more commit above. This slightly edits the text, and I think the text for the right-hand div looks better right-justified.

Only issue now is that the bottom arrows don't really point at quite the right thing, and the overlay box covers up a lot of the time controls. I don't know how we would set this up to work correctly on all form factors, so if it looks good on your phones, I'm inclined to call it good enough since my phone is usually the wonky one.
IMG_9823

@johnarban
Copy link
Contributor Author

i pushed a commit to try to better adjust sizes on the smaller screens

@patudom patudom changed the base branch from main to last-ui-updates April 3, 2024 00:42
@patudom patudom merged commit 5862099 into cosmicds:last-ui-updates Apr 3, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants