Add fren.ai to cosmos/chain-registry #4691
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Update versions.schema.json * Create validate_versionsjson.yml
"URL and name edits"
- Updated assetlist.json to include the native token of the frenai chain. - Added comprehensive metadata for the token including: - Denomination units with base (ufren) and display (fren) units. - Type asset set as sdk.coin. - Coingecko ID set as frenai. - Added keywords for better searchability and classification. - Included social media links (website and Twitter) for the frenai project. - Updated image URIs to point to the Cosmos Chain Registry for both PNG and SVG formats.
- Updated chain.json to include "cosmos_sdk_version" and "ibc_go_version" in the versions array as requested. - Added placeholders for peer IDs since the chain is still in development. - Updated status to "development" to reflect the current state of the chain. - Ensured all URLs point to the Cosmos Chain Registry for accuracy.
Added an optional extended description for more detailed information about fren.ai and updated the image field to an array format.
RPC, REST API and GRPC endpoints added, and description modified.
RPC, GRPC and REST API endpoints added.
Added txs/${txHash}
| { | ||
| "$schema": "../chain.schema.json", | ||
| "chain_name": "frenai", | ||
| "status": "development", |
There was a problem hiding this comment.
This is not a valid status. See:
chain-registry/chain.schema.json
Line 36 in 099474d
| "seeds": [ | ||
| { | ||
| "id": "TBD", | ||
| "address": ":26656", |
There was a problem hiding this comment.
Should we be waiting for more info on these? or were they added as placeholders? If placeholders, please remove them, and if the arrays would be empty, then remove the arrays entirely, as well.
| "name": "frenai", | ||
| "display": "fren", | ||
| "symbol": "FREN", | ||
| "coingecko_id": "frenai", |
There was a problem hiding this comment.
We cannot accept a coingecko ID that isn't recognized by their API
https://api.coingecko.com/api/v3/coins/list
|
Is there still intent to complete this? |
HEGred
approved these changes
Jul 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This pull request adds the initial registry information for the
fren.aichain to thecosmos/chain-registryrepository.Changes
Added
frenai/assetlist.jsonwith the following details:Added
frenai/chain.jsonwith the following details:Notes
frenai/imagesdirectory.Thank you for considering this addition to the
cosmos/chain-registryrepository.