Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Symphony chain.json chain-id to testnet-4 #5692

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

cmancrypto
Copy link

No description provided.

Copy link
Contributor

@ankurdotb ankurdotb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The edits as-is are fine but there can be some improvements:

  1. The chain.json file typically contains URLs to genesis file. I can see this in the Github repo, but the chain.json currently provides it as https://rpc.testnet.symphonychain.org/genesis. This is not a static URL to the genesis file, and did in fact time our with an error. (Hence why the static URL to that that file is better, than a proxy endpoint like it currently has.)
  2. Take a look at the associated version.json file as well and update accordingly.

@cmancrypto
Copy link
Author

Thank you for the review - all should be addressed now.

Copy link
Author

@cmancrypto cmancrypto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for correcting this, I appreciate your help and feedback.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants