Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix rpc client node info check #1591

Merged
merged 2 commits into from
Jun 6, 2024

Conversation

jhernandezb
Copy link
Contributor

@jhernandezb jhernandezb commented Jun 5, 2024

channels field from the node info is specifically used by cometbft p2p system, but in cases like rollkit where that is not used this can be an empty string.

This changes the assert from not empty to only assert is string that was preventing stargate client to initialize correctly.
see example:
https://rpc.rosm.rollkit.dev/status

@webmaster128 webmaster128 merged commit f71cdc3 into cosmos:main Jun 6, 2024
16 checks passed
assafmo added a commit to Stride-Labs/cw-hyperlane that referenced this pull request Jul 2, 2024
byeongsu-hong pushed a commit to many-things/cw-hyperlane that referenced this pull request Jul 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants