Skip to content

Commit

Permalink
remove a few more GetSigners
Browse files Browse the repository at this point in the history
  • Loading branch information
tac0turtle committed Jul 11, 2023
1 parent de6d6a7 commit 548858c
Show file tree
Hide file tree
Showing 5 changed files with 6 additions and 44 deletions.
13 changes: 0 additions & 13 deletions x/auth/types/msgs.go

This file was deleted.

6 changes: 6 additions & 0 deletions x/bank/types/msgs.go
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,12 @@ func NewMsgSend(fromAddr, toAddr sdk.AccAddress, amount sdk.Coins) *MsgSend {
return &MsgSend{FromAddress: fromAddr.String(), ToAddress: toAddr.String(), Amount: amount}
}

// GetSigners Implements Msg.
func (msg MsgSend) GetSigners() []sdk.AccAddress {
fromAddress, _ := sdk.AccAddressFromBech32(msg.FromAddress)
return []sdk.AccAddress{fromAddress}
}

// NewMsgMultiSend - construct arbitrary multi-in, multi-out send msg.
func NewMsgMultiSend(in Input, out []Output) *MsgMultiSend {
return &MsgMultiSend{Inputs: []Input{in}, Outputs: out}
Expand Down
9 changes: 0 additions & 9 deletions x/bank/types/msgs_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -132,15 +132,6 @@ func TestNewMsgSetSendEnabled(t *testing.T) {
assert.Equal(t, "billcoin", msg.UseDefaultFor[0], "msg.UseDefault[0]")
}
}

func TestMsgSendGetSigners(t *testing.T) {
from := sdk.AccAddress([]byte("input111111111111111"))
msg := NewMsgSend(from, sdk.AccAddress{}, sdk.NewCoins())
res := msg.GetSigners()
require.Equal(t, 1, len(res))
require.True(t, from.Equals(res[0]))
}

func TestMsgSetSendEnabledGetSignBytes(t *testing.T) {
msg := NewMsgSetSendEnabled("cartman", []*SendEnabled{{"casafiestacoin", false}, {"kylecoin", true}}, nil)
expected := `{"type":"cosmos-sdk/MsgSetSendEnabled","value":{"authority":"cartman","send_enabled":[{"denom":"casafiestacoin"},{"denom":"kylecoin","enabled":true}]}}`
Expand Down
10 changes: 0 additions & 10 deletions x/group/msgs.go
Original file line number Diff line number Diff line change
Expand Up @@ -199,16 +199,6 @@ func NewMsgSubmitProposal(address string, proposers []string, msgs []sdk.Msg, me
return m, nil
}

// GetSigners returns the expected signers for a MsgSubmitProposal.
func (m MsgSubmitProposal) GetSigners() []sdk.AccAddress {
addrs, err := m.getProposerAccAddresses()
if err != nil {
panic(err)
}

return addrs
}

// getProposerAccAddresses returns the proposers as `[]sdk.AccAddress`.
func (m *MsgSubmitProposal) getProposerAccAddresses() ([]sdk.AccAddress, error) {
addrs := make([]sdk.AccAddress, len(m.Proposers))
Expand Down
12 changes: 0 additions & 12 deletions x/slashing/types/msg.go
Original file line number Diff line number Diff line change
Expand Up @@ -16,15 +16,3 @@ func NewMsgUnjail(validatorAddr sdk.ValAddress) *MsgUnjail {
ValidatorAddr: validatorAddr.String(),
}
}

// GetSigners returns the expected signers for MsgUnjail.
func (msg MsgUnjail) GetSigners() []sdk.AccAddress {
valAddr, _ := sdk.ValAddressFromBech32(msg.ValidatorAddr)
return []sdk.AccAddress{sdk.AccAddress(valAddr)}
}

// GetSigners returns the expected signers for a MsgUpdateParams message.
func (msg MsgUpdateParams) GetSigners() []sdk.AccAddress {
addr, _ := sdk.AccAddressFromBech32(msg.Authority)
return []sdk.AccAddress{addr}
}

0 comments on commit 548858c

Please sign in to comment.