lint

cosmos · Mar 25, 2024 · efd669c · efd669c
1 parent 322c79d
commit efd669c
Show file tree

Hide file tree

Showing 6 changed files with 8 additions and 9 deletions.
diff --git a/x/gov/CHANGELOG.md b/x/gov/CHANGELOG.md
@@ -61,9 +61,9 @@ Ref: https://keepachangelog.com/en/1.0.0/
 
 ### API Breaking Changes
 
-* []() Removes the use of Accouts String method: 
-    * `NewDeposit`, `NewMsgDeposit`, `NewMsgVote`, `NewMsgVoteWeighted`, `NewVote`, `NewProposal`, `NewDeposit`, `NewMsgDeposit`, `NewMsgSubmitProposal`, `NewMsgVote`, `NewMsgVoteWeighted` now takes a string as argument instead of an `sdk.AccAddress`.
-    * `Prompt` and `PromptMetadata` takes an address.Codec as argument.
+* [#19850](https://github.com/cosmos/cosmos-sdk/pull/19850) Removes the use of Accounts String method: 
+    * `NewDeposit`, `NewMsgDeposit`, `NewMsgVote`, `NewMsgVoteWeighted`, `NewVote`, `NewProposal`, `NewMsgDeposit`, `NewMsgSubmitProposal`, `NewMsgVote`, `NewMsgVoteWeighted` now takes a string as argument instead of an `sdk.AccAddress`.
+    * `Prompt` and `PromptMetadata` take as an address.Codec as argument.
     * `SetProposer` takes a String as argument instead of a `fmt.Stringer`.
 * [#19481](https://github.com/cosmos/cosmos-sdk/pull/19481) Migrate module to use `appmodule.Environment`; `NewKeeper` now takes `appmodule.Environment` instead of a store service and no `baseapp.MessageRouter` anymore.
 * [#19481](https://github.com/cosmos/cosmos-sdk/pull/19481) v1beta1 proposal handlers now take a `context.Context` instead of an `sdk.Context`.

diff --git a/x/gov/client/cli/prompt.go b/x/gov/client/cli/prompt.go
@@ -9,10 +9,10 @@ import (
 	"strconv"
 	"strings"
 
-	"cosmossdk.io/core/address"
 	"github.com/manifoldco/promptui"
 	"github.com/spf13/cobra"
 
+	"cosmossdk.io/core/address"
 	authtypes "cosmossdk.io/x/auth/types"
 	"cosmossdk.io/x/gov/types"
 

diff --git a/x/gov/client/cli/prompt_test.go b/x/gov/client/cli/prompt_test.go
@@ -9,7 +9,6 @@ package cli_test
 
 import (
 	"fmt"
-	codectestutil "github.com/cosmos/cosmos-sdk/codec/testutil"
 	"math"
 	"os"
 	"testing"
@@ -19,6 +18,8 @@ import (
 	"github.com/stretchr/testify/require"
 
 	"cosmossdk.io/x/gov/client/cli"
+
+	codectestutil "github.com/cosmos/cosmos-sdk/codec/testutil"
 )
 
 type st struct {

diff --git a/x/gov/simulation/operations.go b/x/gov/simulation/operations.go
@@ -185,11 +185,9 @@ func SimulateMsgSubmitLegacyProposal(
 			return simtypes.NoOpMsg(types.ModuleName, TypeMsgSubmitProposal, "content is nil"), nil, nil
 		}
 
-		//govacc := k.GetGovernanceAccount(ctx)
 		govacc, err := ak.AddressCodec().BytesToString(k.GetGovernanceAccount(ctx).GetAddress())
 		if err != nil {
 			return simtypes.NoOpMsg(types.ModuleName, TypeMsgSubmitProposal, "error getting governance account address"), nil, err
-
 		}
 		contentMsg, err := v1.NewLegacyContent(content, govacc)
 		if err != nil {

diff --git a/x/gov/types/v1/proposal.go b/x/gov/types/v1/proposal.go
@@ -23,7 +23,7 @@ const (
 )
 
 // NewProposal creates a new Proposal instance
-func NewProposal(messages []sdk.Msg, id uint64, submitTime, depositEndTime time.Time, metadata, title, summary string, proposer string, proposalType ProposalType) (Proposal, error) {
+func NewProposal(messages []sdk.Msg, id uint64, submitTime, depositEndTime time.Time, metadata, title, summary, proposer string, proposalType ProposalType) (Proposal, error) {
 	msgs, err := sdktx.SetMsgs(messages)
 	if err != nil {
 		return Proposal{}, err

diff --git a/x/gov/types/v1beta1/msgs_test.go b/x/gov/types/v1beta1/msgs_test.go
@@ -1,12 +1,12 @@
 package v1beta1
 
 import (
-	codectestutil "github.com/cosmos/cosmos-sdk/codec/testutil"
 	"testing"
 
 	"github.com/stretchr/testify/require"
 
 	"github.com/cosmos/cosmos-sdk/codec"
+	codectestutil "github.com/cosmos/cosmos-sdk/codec/testutil"
 	"github.com/cosmos/cosmos-sdk/codec/types"
 	sdk "github.com/cosmos/cosmos-sdk/types"
 )