-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: development environment using gitpod #11835
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know what gitpod is, nor have I ever used it, so I don't really feel comfortable approving. Maybe someone with experience with this can chime in.
Totally fair, let me walk ya through: Gitpod is a browser extension + cloud based container-runner with vscode in it. When you visit a github repository (any even without the .gitpod.yml) you can click the green gitpod button and it checks out the code for you. When you do have the .gitpod.yml file, it even knows where to run the code. So in this case that file is a full cosmos-sdk development enviornment. It runs that as your shell and gives you: I think it would be helpful for onboarding. Users still push to their own repository, it just gets them checked out and going more quickly. |
@@ -0,0 +1,9 @@ | |||
image: ghcr.io/faddat/cosmos |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you link to this image? what does it contain?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, the image is automatically built every hour here and I want to merge it into the cosmos-sdk-- the entire build system for it
https://github.com/faddat/archlinux-docker
The cosmos folder builds that image.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if we merge:
Then that development environment image would be built here, hourly.
It links to an external repository only because well, to put it softly, our docker situation -- and the build situation that comes from using Dockerfiles that are muslc-based and ancient, aren't so great.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's not use external dependencies. If #11768 is a dependency, let's put this PR as draft for now, and open it again when the dep is merged.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
kk
I don't understand why anyone would use this TBH. I'm okay with adding a simple config file though. |
it's my primary development environment |
Hey, so if you want to see this in action, you'd install the gitpod browser extension, and then open up the Juno or osmosis repository. All the tooling is there, and stuff "just works" That is the goal of the change overall. |
Hey, im fine with merging this, I think the missing part for me is to figure out what all the docker image is doing. |
Ill close this for now, lets get the docker image updated then we can reopen this |
Description
Closes: #11817
This PR adds a .gitpod.yml file that uses ghcr.io/faddat/cosmos, an image built to allow the use of any aspect of cosmos. This way, in order to begin working with the sdk, users don't even need to set up a local development environment.
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!
to the type prefix if API or client breaking changeCHANGELOG.md
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!
in the type prefix if API or client breaking change