Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(client/v2): combine autocli and custom cmd within a module #17088

Merged
merged 7 commits into from
Jul 25, 2023
Merged

feat(client/v2): combine autocli and custom cmd within a module #17088

merged 7 commits into from
Jul 25, 2023

Conversation

julienrbrt
Copy link
Member

Description

Closes: #16836

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • run make lint and make test
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@julienrbrt julienrbrt added the backport/v0.50.x PR scheduled for inclusion in the v0.50's next stable release label Jul 21, 2023
@julienrbrt julienrbrt requested a review from a team as a code owner July 21, 2023 16:16
@julienrbrt julienrbrt changed the title feat(client/v2): allow combining AutoCLI cms and existing cms feat(client/v2): allow combining AutoCLI cmds and existing cmds Jul 21, 2023
@github-actions
Copy link
Contributor

@julienrbrt your pull request is missing a changelog!

@julienrbrt
Copy link
Member Author

julienrbrt commented Jul 21, 2023 •
edited
Loading

@julienrbrt your pull request is missing a changelog!

client/v2 is not released, so no changelog needed.

@julienrbrt julienrbrt changed the title feat(client/v2): allow combining AutoCLI cmds and existing cmds feat(client/v2): combine autocli and custom cmd within a module Jul 21, 2023
@julienrbrt julienrbrt disabled auto-merge July 21, 2023 18:21
@julienrbrt julienrbrt requested review from a team, facundomedica and tac0turtle and removed request for alexanderbez, samricotta and a team July 25, 2023 15:00
@julienrbrt julienrbrt added this pull request to the merge queue Jul 25, 2023
Merged via the queue into main with commit fa4d87e Jul 25, 2023
51 of 52 checks passed
@julienrbrt julienrbrt deleted the julien/custom-commands branch July 25, 2023 21:13
mergify bot pushed a commit that referenced this pull request Jul 25, 2023
@julienrbrt @mergify
feat(client/v2): combine autocli and custom cmd within a module (#17088)
f28adc7 
(cherry picked from commit fa4d87e)

# Conflicts:
#	docs/docs/building-modules/10-autocli.md
@mergify mergify bot mentioned this pull request Jul 25, 2023
Merged
julienrbrt added a commit that referenced this pull request Jul 25, 2023
@mergify @julienrbrt
feat(client/v2): combine autocli and custom cmd within a module (back…
5f608b6 
…port #17088) (#17131)

Co-authored-by: Julien Robert <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tac0turtle tac0turtle tac0turtle approved these changes

@facundomedica facundomedica Awaiting requested review from facundomedica

Assignees
No one assigned
Labels
backport/v0.50.x PR scheduled for inclusion in the v0.50's next stable release C:CLI C:x/bank C:x/gov
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow combining AutoCLI commands and existing commands
2 participants
@julienrbrt @tac0turtle